Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

docs(index): include required ngRoute script - #86

Closed
caitp wants to merge 1 commit into
angular:masterfrom
caitp:add-ngRoute
Closed

caitp wants to merge 1 commit into
angular:masterfrom
caitp:add-ngRoute

Conversation

@caitp

@caitp caitp commented Jan 12, 2014

Copy link
Copy Markdown
Contributor

The demo on the homepage using ngRoute was apparently not including the
angular-route script, which has been separate from angular core for some time
now. This seems to have confused some people in the Freenode channel.

I can't seem to test this locally, but it seems like these changes should be
enough to make it clear that the angular-route script needs to be loaded.

The demo on the homepage using ngRoute was apparently not including the
angular-route script, which has been separate from angular core for some
time now. This seems to have confused some people in the Freenode channel.
@petebacondarwin

Copy link
Copy Markdown
Contributor

@caitp - you can test this website locally using a simple web-server. I use:

sudo npm install http-server
cd angularjs.org
http-server

--> Starting up http-server, serving ./ on port: 8080

@petebacondarwin

Copy link
Copy Markdown
Contributor

We also need to fix up the js-fiddle directive for this example. I can do this

@petebacondarwin

Copy link
Copy Markdown
Contributor

Also we need to map in the firebase library!

@petebacondarwin

Copy link
Copy Markdown
Contributor

Fixed by c45478c and 6da51f5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants